Skip to content

chore: remove Protocol38#2707

Merged
MarcoGorelli merged 3 commits intonarwhals-dev:mainfrom
MarcoGorelli:remove-protocol-38
Jul 24, 2025
Merged

chore: remove Protocol38#2707
MarcoGorelli merged 3 commits intonarwhals-dev:mainfrom
MarcoGorelli:remove-protocol-38

Conversation

@MarcoGorelli
Copy link
Member

What type of PR is this? (check all applicable)

  • 💾 Refactor
  • ✨ Feature
  • 🐛 Bug Fix
  • 🔧 Optimization
  • 📝 Documentation
  • ✅ Test
  • 🐳 Other

Related issues

  • Related issue #<issue number>
  • Closes #<issue number>

Checklist

  • Code follows style guide (ruff)
  • Tests added
  • Documented the changes

If you have comments or can explain your changes, please do so below

@dangotbanned
Copy link
Member

dangotbanned commented Jun 20, 2025

Oop I think we need to just rename it to Protocol310

Unless whatever I blabbed about here doesn't hold up 😅

Yeah this was the issue that got fixed in 3.11

Did we remove/override all the __init__ defs in Protocols since then?

@MarcoGorelli
Copy link
Member Author

Did we remove/override all the init defs in Protocols since then?

yeah looks like it

@MarcoGorelli MarcoGorelli marked this pull request as ready for review July 24, 2025 18:52
@MarcoGorelli MarcoGorelli merged commit 2d3a525 into narwhals-dev:main Jul 24, 2025
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants